fix(static): preserve matched handler 404s#3043
Merged
aldas merged 2 commits intoJul 16, 2026
Merged
Conversation
aldas
requested changes
Jul 15, 2026
Contributor
Author
|
Refactored the two test cases into a table-driven test in middleware/static_test.go as requested. go test ./middleware/ -run TestStatic passes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3043 +/- ##
==========================================
+ Coverage 93.17% 93.42% +0.24%
==========================================
Files 43 43
Lines 4501 4732 +231
==========================================
+ Hits 4194 4421 +227
- Misses 189 190 +1
- Partials 118 121 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2775
Preserves 404 responses from matched handlers when HTML5 static fallback is enabled, while retaining the index fallback for router misses, including group route-not-found handling.
Verification:
go test -race ./middleware -run '^TestStaticHTML5PreservesMatchedHandlerNotFound$' -count=1go test -race ./middleware -run '^TestStatic$/^ok,_when_html5_mode_serve_index_for_any_static_file_that_does_not_exist$' -count=1go test -race ./middleware